feat(accounts): add getTokensPnlHistory endpoint to retrieve token Pn…#105
Merged
ifaouibadi merged 2 commits intodevelopfrom Apr 2, 2026
Merged
feat(accounts): add getTokensPnlHistory endpoint to retrieve token Pn…#105ifaouibadi merged 2 commits intodevelopfrom
ifaouibadi merged 2 commits intodevelopfrom
Conversation
…L history with optional date range and interval; enhance portfolio service to support per-token PnL breakdown
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…maries and descriptions; update query DTO for clarity on included fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…L history with optional date range and interval; enhance portfolio service to support per-token PnL breakdown
Note
Medium Risk
Adds a new public API route that can return significantly larger payloads and slightly changes
getPortfolioHistorybehavior via a newincludeTokensPnloption, so there’s moderate risk of performance/regression issues in portfolio history responses.Overview
Adds a new
GET :address/portfolio/tokens/historyendpoint that always includes PnL and can return per-token PnL breakdowns (tokens_pnl), with optional range-based PnL viainclude=pnl-range.Extends
PortfolioService.getPortfolioHistorywith anincludeTokensPnlflag so the existing portfolio history endpoint can keep returning only aggregate PnL unless explicitly requested, and updates Swagger/docs (GetPortfolioHistoryQueryDto,PortfolioHistorySnapshotDto, controller@ApiOperation) to clarifyincludesemantics and wheretokens_pnlis available.Written by Cursor Bugbot for commit c09710f. This will update automatically on new commits. Configure here.